-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] xbps-src: add -A flag for host arch, create masterdir per host arch #46263
Conversation
72d4ed4
to
66c340a
Compare
I like this change a lot. Personally I'm not opposed to remove the redundant flag to |
Following the progress on that PR, it looks very interesting ! 🙏 |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
66c340a
to
e2498d0
Compare
3c09358
to
51c7335
Compare
1a0ee3b
to
6c812a3
Compare
6c812a3
to
af11ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…yntax for void-linux/void-packages#46263 Closes: #187 [via git-merge-pr]
many flags were missing, also updates for new flags: - host arch (void-linux/void-packages#46263) - verbose (void-linux/void-packages#48637)
many flags were missing, also updates for new flags: - host arch (void-linux/void-packages#46263) - verbose (void-linux/void-packages#48637)
many flags were missing, also updates for new flags: - host arch (void-linux/void-packages#46263) - verbose (void-linux/void-packages#48637)
Testing the changes
Overview
XBPS_ARCH
, e.g.masterdir-x86_64
XBPS_ARCH
can be done with-A <arch>
-m <masterdir>
, and overrides whatever-A
would set[binary-]bootstrap
no longer (ab)uses$XBPS_TARGET_PKG
for setting the masterdir's host architectureBefore
default:
nondefault masterdir:
specific host arch:
cross with specific host arch:
After
default:
nondefault masterdir:
specific host arch:
cross with specific host arch:
Thoughts
By removing thebuildbot config will be changed[binary-]bootstrap [arch]
invocation style, there will be changes needed to buildbot configuration. If left in, should-A <arch>
take priority over[arch]
if both are specified?This could be an opportunity to change the name ofif this changes, it will be separate; there's too much to change both coherentlymasterdir
to something else, likemasterdir
(the containers CI uses are already calledvoid-buildroot-<libc>
)TODO